Skip to content

[two-scale-heat-conduction] Fix parallel macro: Write data only for interior elements #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2025
Merged

[two-scale-heat-conduction] Fix parallel macro: Write data only for interior elements #665

merged 2 commits into from
Sep 7, 2025

Conversation

mathiskelm
Copy link
Collaborator

Coupling data was still written from the solution vector, not limited to interior elements / coupling points.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@mathiskelm mathiskelm requested a review from IshaanDesai August 26, 2025 09:28
@IshaanDesai IshaanDesai marked this pull request as ready for review September 7, 2025 12:38
IshaanDesai
IshaanDesai approved these changes Sep 7, 2025
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out this patch and checked the results and they are now fixed.

@IshaanDesai IshaanDesai merged commit 8a80f2c into develop Sep 7, 2025
1 check passed
@IshaanDesai IshaanDesai deleted the fix/two-scale-heat-conduction/parallel-macro-dumux branch September 7, 2025 12:49
IshaanDesai added a commit that referenced this pull request Sep 7, 2025
@IshaanDesai
Add missing changelog entry for #665
24d9214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiskelm @IshaanDesai